Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled overflow in int8 SVDF evaluation #2721

Open
VictorDominguite opened this issue Oct 9, 2024 · 2 comments
Open

Unhandled overflow in int8 SVDF evaluation #2721

VictorDominguite opened this issue Oct 9, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@VictorDominguite
Copy link

When calculating the values to be inserted in the SVDF operator’s activation state in the svdf_common.cc file, there seems to be an error while handling overflow.
In line 111 the value for the dot_prod variable is limited to the interval of valid int8 values, [-128, 127]. But then, in line 115, the activation state’s zero point is added to dot_prod, which may lead to an unhandled overflow.

@ddavis-2015 ddavis-2015 added the bug Something isn't working label Oct 10, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

"This issue is being marked as stale due to inactivity. Remove label or comment to prevent closure in 5 days."

@github-actions github-actions bot added the Stale label Nov 4, 2024
@ddavis-2015 ddavis-2015 removed the Stale label Nov 4, 2024
@renatocan
Copy link

Commenting to prevent closing the issue.

My colleagues @VictorDominguite and Luiz Baptista have proposed a potential solution for this issue. We'll create a PR to further discuss and implement it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants