Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add INT32 Support to Sub #2720

Closed
HemanthSai7 opened this issue Oct 9, 2024 · 7 comments · May be fixed by #3037
Closed

Add INT32 Support to Sub #2720

HemanthSai7 opened this issue Oct 9, 2024 · 7 comments · May be fixed by #3037
Assignees
Labels

Comments

@HemanthSai7
Copy link

When trying to deploy the model on ESP32S3, I get a warning called SUB failed to invoke INT32 not supported. I have fixed it and I want to contribute by opening a PR.

@ddavis-2015
Copy link
Member

ddavis-2015 commented Oct 9, 2024

@HemanthSai7

TFLM (aka LRTM) welcomes PR contributions! Please submit your PR at your leisure with these rules in mind:

  • All code must comply with Google C++ style rules
  • All added files (if any) must build through both Makefile and Bazel
  • Unit tests that allow complete code coverage must be submitted

So you would need unit tests in sub_test.cc for INT32 that cover both broadcast and non-broadcast (just like the INT16). Also be aware that if this is your first time submitting code, you will need to sign the CLA. You will be presented with information on how to do this when you submit the PR.

Also, somewhere in the PR description there must be a line bug=#xxxx where xxxx is this issue number.

@HemanthSai7
Copy link
Author

Okay, I will keep these points in mind.

Copy link
Contributor

"This issue is being marked as stale due to inactivity. Remove label or comment to prevent closure in 5 days."

@github-actions github-actions bot added the Stale label Nov 16, 2024
@HemanthSai7
Copy link
Author

This issue is not stale. I will create a PR.

@github-actions github-actions bot removed the Stale label Nov 20, 2024
Copy link
Contributor

"This issue is being marked as stale due to inactivity. Remove label or comment to prevent closure in 5 days."

@github-actions github-actions bot added the Stale label Dec 16, 2024
Copy link
Contributor

"This issue is being closed because it has been marked as
stale for 5 days with no further activity."

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 22, 2024
@HemanthSai7
Copy link
Author

How to reopen this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants