-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Report] TTNN typecast operation fails when the tensor is on host #16279
Comments
Hi @sjameelTT, we are currently facing this issue with our MLIR-based compiler. @jnie-TT mentioned that you spoke with him and have plans to improve the typecast operation to support casting on the host. I've created this issue so we can track our progress on this matter. |
Any reason why we can't do this on device? |
@sjameelTT because typecast on device only works with tilized data, but then tilize on device works with only specific data types, so sometimes we need to fallback to host. This issue is related: #16270 |
I see, I remember now. We definitely want to support typecast on row major and tilize for all data types before adding typecast on host. |
Great, thanks for letting us know. Let's keep this issue opened to track the progress. |
Hi, @sjameelTT. Are there any updates regarding Typecast op enhancements? |
hey @sdjordjevicTT sorry I think this was improperly assigned. @ayerofieiev-tt and @TT-BrianLiu are in charge of tensor creation and storage (if I'm not mistaken). Can you guys triage this? |
Thanks @ntarafdar for including @ayerofieiev-tt and @TT-BrianLiu into the conversation. |
Describe the bug
TTNN typecast operation fails with the following message when the tensor is present on the host:
To Reproduce
Steps to reproduce the behavior:
The test should fail with the following exception:
Expected behavior
Expected behavior should not be the failure, the typecast op should under the hood do the conversion on the host.
Screenshots
/
Please complete the following environment information:
Additional context
Instead of using the typecast op, we can use to_dtype to convert on the host, but I believe that the semantics of typecast should cover this case as well.
The text was updated successfully, but these errors were encountered: