Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul Stable Diffusion 1.4 web demo #18182

Open
bgoelTT opened this issue Feb 23, 2025 · 0 comments
Open

Overhaul Stable Diffusion 1.4 web demo #18182

bgoelTT opened this issue Feb 23, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@bgoelTT
Copy link

bgoelTT commented Feb 23, 2025

The current web demo's backend relies on reading & writing to a file (models/demos/wormhole/stable_diffusion/demo/web_demo/input_prompts.json) to facilitate the transmission of data between the flask server and the model backend process. This method makes no guarantee of mutual exclusion, sometimes leading to race conditions where the flask server is writing to the file while the model backend is reading, clobbering the file and crashing the server. Additionally, if multiple prompt submissions occur from e.g. 16 simulatenous users, the lack of mutual exclusion leads to undefined and error-prone behaviour.

This issue can be closed when a proper data-transmission method has been implemented, perhaps using python's queue.Queue which is thread-safe.

@bgoelTT bgoelTT added the bug Something isn't working label Feb 23, 2025
@bgoelTT bgoelTT self-assigned this Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant