Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some data movement ops don't pass memory config #2038

Open
odjuricicTT opened this issue Jan 30, 2025 · 3 comments
Open

Some data movement ops don't pass memory config #2038

odjuricicTT opened this issue Jan 30, 2025 · 3 comments
Assignees
Labels
TTNN Dialect Issues related to TTNN dialect

Comments

@odjuricicTT
Copy link
Contributor

E.g. reshape:
https://github.com/tenstorrent/tt-mlir/blob/main/runtime/lib/ttnn/operations/data_movement/reshape.cpp#L16
Should pass the memory config optional parameter when invoked.

In order for optimizer to work, every op that supports it needs to either pass memory_config or the output tensor.

@odjuricicTT
Copy link
Contributor Author

@jnie-TT Can you take a look at this?

@odjuricicTT odjuricicTT added this to the [Performance - 2] March milestone Jan 30, 2025
@sdjordjevicTT
Copy link
Contributor

sdjordjevicTT commented Feb 3, 2025

@mtopalovicTT @svuckovicTT @azecevicTT @jserbedzijaTT FYI

This is probably on us @odjuricicTT, most of the ops that don't have memory_config parameter mostly don't have memory_config attribute in TTNN dialect:

def TTNN_ReshapeOp : TTNN_Op<"reshape"> {
let summary = "Reshape op.";
let description = [{
Reshape tensor.
}];
let arguments = (ins AnyRankedTensor:$input,
I32ArrayAttr:$shape);
let results = (outs AnyRankedTensor:$result);
let hasVerifier = 1;
}

Can you give us a priority list of ops that we should handle first before we handle this systematically?

@sdjordjevicTT sdjordjevicTT self-assigned this Feb 3, 2025
@sdjordjevicTT sdjordjevicTT added the TTNN Dialect Issues related to TTNN dialect label Feb 3, 2025
@odjuricicTT
Copy link
Contributor Author

@sdjordjevicTT Concat and reshape are blockers for now. Agreed that this should be systematically handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TTNN Dialect Issues related to TTNN dialect
Projects
None yet
Development

No branches or pull requests

2 participants