Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to vue.js #85

Closed
teobais opened this issue Oct 22, 2021 · 10 comments
Closed

Port to vue.js #85

teobais opened this issue Oct 22, 2021 · 10 comments

Comments

@teobais
Copy link
Owner

teobais commented Oct 22, 2021

According to https://stackoverflow.com/questions/69460136/percircle-dynamic-data-not-updating-in-vue-js and the latest trends, it would be nice to have a vuejs port of percircle

@miller-kevin
Copy link

I have been using this in my vue app (thank you for making this, by the way), and had intended to make a vue wrapper for it. I'll happily submit a PR when I finish. Do you want it to be in a different repo?

@teobais
Copy link
Owner Author

teobais commented Jan 12, 2022

Thanks for using percircle, Kevin, that means a lot! Feel free to submit your PR as a different branch of the current repo, goal being the newly introduced branch (vuejs port) will become the master branch (subsequently positioning the current master as a secondary branch), thereby introducing the phasing out of the jQuery support in the long run (which will not be earlier than 2023 given the current usage).

Looking forward to reviewing your PR :)

@miller-kevin
Copy link

@teobais Quick heads up, went to check the demo site linked in the github and it's down

@teobais
Copy link
Owner Author

teobais commented Jan 13, 2022

Good catch, thanks. Updated old references, should be working now.

@teobais
Copy link
Owner Author

teobais commented Jan 13, 2022

@miller-kevin shall I already assign this issue to you given the discussion above?

@miller-kevin
Copy link

Yes, I'll take it from here. Will let you know when the Vue rewrite is done

@teobais
Copy link
Owner Author

teobais commented Jan 13, 2022

btw the intention of this issue is to fully migrate percircle to vuejs (no jQuery involved - percircle behavior developed in vuejs). If that is too costly for the time being, a wrapper is also fine and could be seen as a first step towards a future migration to vuejs.

@miller-kevin
Copy link

miller-kevin commented Jan 13, 2022

Yeah, I've already removed jQuery as a dependency. I had originally planned for a wrapper, but what I'm doing is definitely a full conversion haha

@miller-kevin
Copy link

Feel free to review here #86

Needs some more testing (and maybe some back and forth with you about some of the changes made), but it definitely works.

I plan to implement it in my apps once I've had more time to test it

@teobais
Copy link
Owner Author

teobais commented Jan 15, 2022

Closed with #86 . Thank you again, @miller-kevin 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants