Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why includes jackson-datatype-jsr310 in terasoluna-gfw-common-dependencies? #737

Open
3 tasks
kazuki43zoo opened this issue Sep 9, 2017 · 2 comments
Open
3 tasks

Comments

@kazuki43zoo
Copy link
Contributor

kazuki43zoo commented Sep 9, 2017

Description

In current pom definition, the terasoluna-gfw-common-dependencies has dependency for the jackson-datatype-jsr310 as follow:

<dependency>
<groupId>com.fasterxml.jackson.datatype</groupId>
<artifactId>jackson-datatype-jsr310</artifactId>
</dependency>

Is correct this dependency definition?
I think better this dependency separate like the terasoluna-gfw-jodatime-dependencies.
What do you think?

Possible Solutions

(Please write ideas or candidates of solutions for the problem if you have)

Affects Version/s

  • 5.X.X.RELEASE
  • 1.X.X.RELEASE

Fix Version/s

(To be written later by project member)

  • 5.4.0 (master)
  • 5.3.1 (5.3.x)

Final Solution

(To be written later by project member)

Migrating Guide

(To be selected later by project member)

  • Required
  • Not Required

Issue Links

  • #XXX
@itouyun
Copy link
Contributor

itouyun commented Sep 29, 2017

Thank you for your making issue!
Would we consider with #736 ?

@yoshikawaa
Please investigate this issue definition of jackson-datatype-jsr310.

@yoshikawaa
Copy link
Contributor

@itouyun @kazuki43zoo
jackson-datatype-jsr310 was added at #562 (Support JSR310 on JSON and MyBatis).
But I could not find a certain reason to add it to terasoluna-gfw-common-dependencies.

I think it is correct to create a library like terasoluna-gfw-jsr310-dependencies or terasoluna-gfw-datetime-dependencies and move it to that. (I agree opinion of @kazuki43zoo )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants