Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AEAD.Lazy does not throw exception for failed authentication #89

Closed
gnarula opened this issue Nov 19, 2020 · 0 comments · Fixed by #90
Closed

AEAD.Lazy does not throw exception for failed authentication #89

gnarula opened this issue Nov 19, 2020 · 0 comments · Fixed by #90

Comments

@gnarula
Copy link
Contributor

gnarula commented Nov 19, 2020

AEAD.Lazy silently decrypts a ciphertext which fails authentication. For instance, calling decrypt for XChaCha20-Poly1305 ignores the return value of cryptoAeadXChaCha20Poly1305IetfDecrypt()

lazysodium-java/src/main/java/com/goterl/lazycode/lazysodium/LazySodium.java

Line 2412 in ea27165

cryptoAeadXChaCha20Poly1305IetfDecrypt(

IMHO, the decrypt method should throw an exception in order to alert the user of the library that the decryption was unsuccessful.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Throw exception on AEAD decryption failure gnarula/lazysodium-java
1 participant
@gnarula