Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] wasm params.MaxContractGas is not properly limit gas usage #501

Closed
yun-yeo opened this issue Jun 14, 2021 · 0 comments
Closed

[BUG] wasm params.MaxContractGas is not properly limit gas usage #501

yun-yeo opened this issue Jun 14, 2021 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@yun-yeo
Copy link
Contributor

yun-yeo commented Jun 14, 2021

Describe the bug
Current core does not properly limit the gas usage with its params.MaxContractGas. It is only asserted per each messages, not including its sub-messages.

Ex) when we execute msg1 which is executing msg2, msg3, ... msgn, the limit is applied per each messages. It is supposed to be applied to sum of all gas usages of the messages to properly limit the gas.

To Reproduce
execute wasm message which is executing sub-messages

Context & versions
v0.4.0 + v0.5.0-beta4

(if applicable) suggested solution
Set new gas meter with limit at msg server

@yun-yeo yun-yeo added the bug Something isn't working label Jun 14, 2021
@yun-yeo yun-yeo self-assigned this Jun 14, 2021
@yun-yeo yun-yeo added this to the Columbus-5 milestone Jun 14, 2021
@yun-yeo yun-yeo closed this as completed Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant