New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TxApi.decode() has bug. #324

Closed

comsy-gcp opened this issue Aug 2, 2022 · 1 comment · Fixed by #325

comsy-gcp commented Aug 2, 2022

https://github.com/terra-money/terra.js/blob/main/src/client/lcd/api/TxAPI.ts
line 386
decode() function has bug.
Tx.fromBuffer needs "isClassic" for classic terra.

return Tx.fromBuffer(Buffer.from(encodedTx, 'base64'));
fix to
return Tx.fromBuffer(Buffer.from(encodedTx, 'base64'), this.lcd.config.isClassic);

please confirm
thank you.

Contributor

Vritra4 commented Aug 3, 2022

thanks for the report! it'll be fixed.

Vritra4 mentioned this issue

fix decode() #325

Merged

Vritra4 closed this as completed in #325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment