-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Workspace optimizer and other breaking changes! #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inconsistent return was causing issues.
}); | ||
// pause for account sequence to update. | ||
// eslint-disable-next-line no-promise-executor-return | ||
await new Promise((r) => setTimeout(r, 1000)); |
Check failure
Code scanning / ESLint
disallow returning values from Promise executor functions
Return values from promise executor functions cannot be read.
const contractConfig = ( | ||
allConfig[network] | ||
&& allConfig[network].contracts | ||
&& allConfig[network].contracts![contract] |
Check warning
Code scanning / ESLint
Disallows non-null assertions using the `!` postfix operator
Forbidden non-null assertion.
This was referenced Aug 1, 2022
Closed
BREAKING CHANGE: Parameters for deployment tasks, client execute, and client query have been rearranged for usability.
df4227e
to
aea1f88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a biggie, so let me break it down:
New features
New commands
terrain contract:build
terrain contract:optimize
Breaking changes
Before
After
Before
After
contracts
key.Before
After
Miscellaneous changes
src/lib/waitForInclusionBlock.ts
helper since this is now included in Terra.js