-
-
Notifications
You must be signed in to change notification settings - Fork 237
feat!: Handle new region parameter introduced in terraform-aws 6.0 #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Handle new region parameter introduced in terraform-aws 6.0 #156
Conversation
9a182a4
to
eb66684
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bryantbiggs WDYT? Should we add support for the newly introduced "region" argument in all Terraform AWS modules? I personally think - yes, but I am trying to think about different scenarios when this can be a bad idea.
eb66684
to
f5360f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for Bryant's feedback... I think we should add region
on all resources, even if some of them are rather global (like aws_route53_record
).
Unfortunately, global resources like |
yes, I completely agree. since this is a breaking change, could we also bump the MSV of Terraform to at least 1.10.0 as well? this covers both the optional variable attributes and the new ephemeral secrets/inputs |
I pushed a new commit, tell me if it's OK for you. |
87c6e70
to
4957876
Compare
…ew features (optional variable attributes, ephemeral values...)
4957876
to
93742d3
Compare
cc8c826
to
b7558a3
Compare
b7558a3
to
02cbfb3
Compare
This PR is included in version 6.0.0 🎉 |
👍 thanks a lot to both of you for your responsiveness! |
@bryantbiggs I think you have to be careful with this, because as far as I know some people have TF version pinned at 1.5.x, because the license was changed to BSL from 1.6.0 onwards |
I mean, unfortunately thats outside of our control. The license change should not affect module users - that should really only affect folks who have created a competing business and will have to adhere to the license |
Unfortunately it also breaks OpenTofu support |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Handle the new
region
parameter introduced in terrafrom-aws provider 6.0.Motivation and Context
This allows to specify the region to create the resources into, instead of relying on a dedicated provider instance.
Breaking Changes
This requires terraform-aws >= 6.0.
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request