docs: Updated description and examples of name_prefix argument #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ME.md to adjust to the 6 character limit that the value can take. Fixes issue terraform-aws-modules#161
README.md
Outdated
| @@ -252,7 +252,7 @@ module "lb" { | |||
| | load\_balancer\_type | The type of load balancer to create. Possible values are application or network. | `string` | `"application"` | no | | |||
| | load\_balancer\_update\_timeout | Timeout value when updating the ALB. | `string` | `"10m"` | no | | |||
| | name | The resource name and Name tag of the load balancer. | `string` | `null` | no | | |||
| | name\_prefix | The resource name prefix and Name tag of the load balancer. | `string` | `null` | no | | |||
| | name\_prefix | The resource name prefix and Name tag of the load balancer. Cannot be longer than 6 characters. | `string` | `null` | no | | |||
There was a problem hiding this comment.
Please update the content of variables.tf where this description of variables is taken from by pre-commit-terraform hook.
There was a problem hiding this comment.
Thanks for the correction I didn't noticed that. I've commited a new change with the observation.
…ME.md and variables.tf to adjust to the 6 character limit that the value can take. Fixes issue terraform-aws-modules#161
antonbabenko
changed the title
|
Thanks, @nahuel242 ! v5.6.0 has been released. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ME.md to adjust to the 6 character limit that the value can take. Fixes issue #161
Description
Motivation and Context
Updated description and examples of name_prefix argument in README.md to adjust to the 6 character limit that the value can take.
Related to issue #161
Breaking Changes
No
How Has This Been Tested?
No testing other than looking at the modified file as this is an update in the README.md