Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target group target_type variable and depends_on #37

Merged
merged 1 commit into from
Feb 15, 2018
Merged

Add target group target_type variable and depends_on #37

merged 1 commit into from
Feb 15, 2018

Conversation

angusfz
Copy link
Contributor

@angusfz angusfz commented Feb 9, 2018

Add ALB target group target_type variable and depends_on to alb relate resource.

Copy link
Contributor

@brandonjbjelland brandonjbjelland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandonjbjelland
Copy link
Contributor

Looks good to me. I ran tests and they pass. Thanks for the contribution!

@brandonjbjelland brandonjbjelland merged commit 002690d into terraform-aws-modules:master Feb 15, 2018
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants