Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding CI to module #5

Merged
merged 32 commits into from
Oct 24, 2017
Merged

Adding CI to module #5

merged 32 commits into from
Oct 24, 2017

Conversation

brandonjbjelland
Copy link
Contributor

Added

  • TravisCI configuration added and now passing.
  • badge added to docs. (will alter this to use TravisCI under terraform-aws-modules once reviewed)
  • permissions section now in the example readme.
  • placeholder shell script added for CI deployment. Eventually this should conditionally release to the registry when those APIs become available.

Changed

  • altered tf variable aws_region to region.
  • replaced hardcoding the region to instead use a random region as retrieved by an awscli docker container within CI.
  • example cert is now a regionally-specific resource enabling tests to run in various regions at once and not collide.
  • ruby version bump means Rhcl becomes rhcl.

@brandonjbjelland
migrating to the terraform registry and new org. Tests fixed and expa…
406d7d1 
…nded.
@brandonjbjelland
updated docs
46634e9
@brandonjbjelland
Giving thanks to contributors in the changelog
a52a6a7
@brandonjbjelland
debugging rhcl failure
2af9897
@brandonjbjelland
PR #1 feedback addressed - see CHANGELOG
6a72c49
@brandonjbjelland
Initial add of travis CI testing.
1e82b52
@brandonjbjelland
altered CI user permissions and updated README
ccfd2e5
@brandonjbjelland
Tests passing locally with this permission set. Added Travis badge.
4d045d8
@brandonjbjelland
aws_region to region, added necessary variables to help CI along
c25dadf
@brandonjbjelland
back one less dir?
75ff816
@brandonjbjelland
the sed was missing the file. Should be working now
ae1e9b7
@brandonjbjelland
skipping validation of test fixtures
d6c6df6
@brandonjbjelland
derp. tested the sed command and didnt revert its result. Trying CI a…
11d3b87 
…gain
@brandonjbjelland
rhcl problems. caps has bit me in the past here
02bb8b9
@brandonjbjelland
trying the validation of fixtures once more in CI
d1bea41
@brandonjbjelland
modified the sed command to hit the exact directory target
e9be619
@brandonjbjelland
typo corrected [skip ci]
a318154
@brandonjbjelland
README typo corrected [skip ci]
85c2c13
@brandonjbjelland
fixed up the policy creation. tests not working atm
9e1857b
@brandonjbjelland
pre-commit config now in place
4ed1c87
@brandonjbjelland
environment variable for region needed to be set. Handing this better…
1452128 
… in the next iteration.
@brandonjbjelland
merging master to branch
b4593b1
@brandonjbjelland
unhardcoded region
148470c
@brandonjbjelland
trying to grab aws region via docker awscli
e766054
@brandonjbjelland
fixed up awscli command. 😅
70daa08
@brandonjbjelland
making cert a regionally specific thing for tests to run in various r…
2fa63e3 
…egions at once
@brandonjbjelland
Add CI to project
ef24c0f 
## Added
* TravisCI configuration added and now passing.
* badge added to docs.
* permissions section now in the example readme.
* placeholder shell script added for CI deployment. Eventually this should conditionally release to the registry when those APIs become available.

## Changed
* altered tf variable `aws_region` to `region`.
* replaced hardcoding the region to instead use a random region as retrieved by an awscli docker container within CI.
* example cert is now a regionally-specific resource enabling tests to run in various regions at once and not collide.
* ruby version bump means `Rhcl` becomes `rhcl`.
@brandonjbjelland
changelog to reflect updates
dfdb33f
@brandonjbjelland
Merge pull request #2 from run-at-scale/feature/3_add_CI
07e93f7 
changelog to reflect updates
@brandonjbjelland
merge conficts resolved
8e46b3f
@brandonjbjelland brandonjbjelland self-assigned this Oct 20, 2017
@brandonjbjelland
Copy link
Contributor Author

Resolves #3 once merged.

@brandonjbjelland
Copy link
Contributor Author

brandonjbjelland commented Oct 20, 2017 •
edited
Loading

This is the build of the PR: https://travis-ci.org/run-at-scale/terraform-aws-alb/builds/290279127

I suppose in this PR state, it's probably worth setting up Travis for this project. Sending that request to the org now. @antonbabenko you may need to respond.

@brandonjbjelland
Copy link
Contributor Author

Thanks for the travis permissions @antonbabenko but it looks like one more step is needed: making me admin of the repo so I can both do the registry publish and enable the TravisCI build.

I get the following within TraivsCI and can't enable due to perms:
screen shot 2017-10-24 at 12 59 05 am

I see the following in the terraform registry:
screen shot 2017-10-24 at 12 43 56 am

Unfortunately it looks like kitchen terraform doesn't fully support version 0.10.x just yet so I'm getting some spotty results. I'm going to disable nightly builds when this is up to avoid the flip flop of status due to incompatibility.

@antonbabenko
Copy link
Member

Done.

@brandonjbjelland
Copy link
Contributor Author

Hmm since the incoming branch is from a forked repo I can't run the build until this is merged. Doing that now.

@brandonjbjelland brandonjbjelland merged commit 5e7184c into terraform-aws-modules:master Oct 24, 2017
@brandonjbjelland brandonjbjelland mentioned this pull request Oct 25, 2017
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@brandonjbjelland brandonjbjelland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandonjbjelland @antonbabenko