-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ feature ] Add support for aws_dms_s3_endpoint
resource
#34
Comments
This issue has been automatically marked as stale because it has been open 30 days |
This issue has been automatically marked as stale because it has been open 30 days |
This issue was automatically closed because of stale in 10 days |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Is your request related to a new offering from AWS?
Yes ✅ this functionality was added in version 4.45.0 of the AWS provider.
Is your request related to a problem? Please describe.
I recently opened a new PR trying to add this functionality but discovered that
there was more work to it than just adding the variable to the
endpoint_settings
. Helpfully, @bryantbiggs mentioned that there was more workto be done in order to get the functionality of version 4.45.0 of the AWS
provider.
Describe the solution you'd like.
I'd like to be able to configure an S3 Endpoint with the
aws_dms_s3_endpoint
resource rather than the
aws_dms_endpoint
resource when configuring DMS usingthis module. This would be helpful because the
expected_bucket_owner
is onlyconfigurable through the
aws_dms_s3_endpoint
. Also the setting for S3 is onlysupported on version
3.4.7
of the AWS DMS service.Describe alternatives you've considered.
None. I think it's a straightforward refactor even if it is a more complicated
change than adding a new property.
Additional context
As I mentioned earlier, the S3 setting is only available in version
3.4.7
andabove so it would be great to have some cross-variable validation to help
prevent users from messing up the configuration.
The text was updated successfully, but these errors were encountered: