Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixes small README typos #37

Merged
merged 3 commits into from
Jan 28, 2023
Merged

fix: Fixes small README typos #37

merged 3 commits into from
Jan 28, 2023

Conversation

saralein
Copy link
Contributor

@saralein saralein commented Jan 26, 2023 •
edited
Loading

Description

This PR fixes two small typos in the repository README.

Motivation and Context

These distracted me slightly while reading through this paragraph, and I wanted to provide smoother reading for others.

Breaking Changes

None.

@saralein saralein changed the title Fix: Fixes small README typos fix: Fixes small README typos Jan 26, 2023
@saralein
Copy link
Contributor Author

Possible update to PR title: docs or fix? Assuming perhaps docs but leaving for the moment.

@bryantbiggs
Copy link
Member

@saralein it looks like I can't update your branch - I've opened a PR that once you add in those changes the checks should pass and we can merge this in saralein#1

@saralein
Merge pull request #1 from bryantbiggs/ci/fix
eb95487 
fix: Update CI workflow to avoid GitHub rate limiting
bryantbiggs
bryantbiggs approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs merged commit f67f77d into terraform-aws-modules:master Jan 28, 2023
@saralein
Copy link
Contributor Author

@saralein it looks like I can't update your branch - I've opened a PR that once you add in those changes the checks should pass and we can merge this in saralein#1

Thank you very much. I believe I was mucking around with settings over there, thinking no one would need to mess with it.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2023
@antonbabenko
Copy link
Member

This PR is included in version 2.0.0 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saralein @bryantbiggs @antonbabenko