fix: Complete ECS example (IAM role not configured in ASG) #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Complete ECS Example don't work. Don't configure the IAM Role in ASG. This is because the example uses launch configuration and the variable iam_instance_profile_arn. The variable iam_instance_profile_arn should be use with launch template. With launch configurations should use the variable iam_instance_profile_name. fixes terraform-aws-modules#42
mkostrikin
force-pushed
the
fix-ecs-example
branch
from
98db222 to
4e19ce8
Compare
mkostrikin
changed the title
antonbabenko
changed the title
|
Thanks, Maksim! v3.3.0 has been just released. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Complete ECS Example don't work. Don't configure the IAM Role in ASG.
Motivation and Context
This is because the example uses launch configuration and the variable iam_instance_profile_arn.
The variable iam_instance_profile_arn should be use with launch template.
With launch configurations should use the variable iam_instance_profile_name.
fixes #42
Breaking Changes
none
How Has This Been Tested?
examples/*projects in own aws infrastructure.