feat!: Upgrade module to include capacity providers and bump minimum supported versions #60

bryantbiggs · 2022-06-03T22:03:33Z

Description

Minimum supported version of Terraform AWS provider updated to v4.6 to support the latest resources utilized
Minimum supported version of Terraform updated to v1.0
ecs-instance-profile sub-module has been removed; this functionality is available through the terraform-aws-modules/terraform-aws-autoscaling module starting with version v6.5.0. Please see the examples/ec2 example for a demonstration on how to use and integrate with the terraform-aws-autoscaling module.
The container_insights and capacity_providers variables have been replaced by new variables

See UPGRADE-4.0.md for more details

Motivation and Context

Update module to use current GA versions of provider and Terraform
Incorporate functionality to support EC2 AutoScaling Group capacity provider
Provide complete functionality for ECS cluster
Move IAM instance profile out to AutoScaling group module where it is commonly used (by ECS, EKS, or standalone)
Lays the groundwork for adding service & task definition functionality in sub-module

Breaking Changes

Yes, see UPGRADE-4.0.md for more details

How Has This Been Tested?

I have updated at least one of the examples/* to demonstrate and validate my change(s)
I have tested and validated these changes using one or more of the provided examples/* projects
I have executed pre-commit run -a on my pull request

…roup, and minimum supported versions

…ce` moduel to come

…avoid disruption

bryantbiggs · 2022-06-04T01:01:39Z

UPGRADE-4.0.md

+  source  = "terraform-aws-modules/ecs/aws//modules/ecs-instance-profile"
+  # Users can pin and stay on v3.5.0 until they able to use the IAM instance
+  # profile provided through the autoscaling group module
+  version = "3.5.0"


I did try to migrate the instance role and profile from the sub-module in v3.x to the autoscaling group, but the instance profile path and name is different from the role and currently the autoscaling group module makes the assumption that the IAM role and instance profile names and paths are the same. Users can pin their profile to v3.5.0 and continue to use without issue and avoid any disruption when upgrading

bryantbiggs · 2022-06-04T01:03:10Z

examples/ec2/main.tf

+  user_data                       = base64encode(local.user_data)
+  ignore_desired_capacity_changes = true
+
+  create_iam_instance_profile = true


Lines L128-L134 are the replacement for the ecs-instance-profile sub-module, which is provided through the autoscaling group now. The plan is to replace this similar functionality in the EKS module and rely on the ASG module which will reduce quite a bit of code through consolidation (you can see some of that here but that changeset doesn't yet include the removal of the IAM role and instance profile since that was a recent change to the ASG module)

bryantbiggs · 2022-06-04T01:08:27Z

examples/ec2/versions.tf


  required_providers {
    aws = {
      source  = "hashicorp/aws"
-      version = ">= 2.48"
+      version = ">= 4.6"


why v4.6 - this is the latest change for ECS service which was released in v4.6. The service sub-module is coming up next which will use this. We could do v4.0 but figured this was more grounded around a feature set that would be used

I agree. It is totally ok to rely on a newer version in such a major release.

bryantbiggs · 2022-06-04T01:09:12Z

examples/fargate/README.md

+
+Configuration in this directory creates:
+
+- ECS cluster using Fargate (on-demand and spot) capacity provider


Once the service sub-module is added, its usage will be added here along with example usage of using ALB and NLB to route traffic to tasks.

bryantbiggs · 2022-06-04T01:11:02Z

modules/service/README.md

+
+⚠️ Module is under active development ⚠️
+
+## TODO


This just lays out the rough shape for this sub-module, it will be built out in subsequent PRs

bryantbiggs · 2022-06-04T01:16:47Z

modules/service/main.tf

@@ -0,0 +1 @@
+locals {}


Worlds best module, simple elegance 🤣

outputs.tf

antonbabenko

Looks good, there will be a bit more when more code is there :)

UPGRADE-4.0.md

examples/ec2/main.tf

antonbabenko · 2022-06-07T09:13:13Z

examples/ec2/versions.tf


  required_providers {
    aws = {
      source  = "hashicorp/aws"
-      version = ">= 2.48"
+      version = ">= 4.6"


I agree. It is totally ok to rely on a newer version in such a major release.

main.tf

outputs.tf

antonbabenko

LGTM

## [4.0.0](v3.5.0...v4.0.0) (2022-06-08) ### ⚠ BREAKING CHANGES * Upgrade module to include capacity providers and bump minimum supported versions (#60) ### Features * Upgrade module to include capacity providers and bump minimum supported versions ([#60](#60)) ([7a41657](7a41657))

antonbabenko · 2022-06-08T13:26:42Z

This PR is included in version 4.0.0 🎉

github-actions · 2022-11-08T02:32:27Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

bryantbiggs added 4 commits June 2, 2022 12:39

feat!: Upgrade module to include capacity providers, cloudwatch log g…

fac6255

…roup, and minimum supported versions

refactor: Update examples to utilize latest changes, setup new `servi…

4b34b8e

…ce` moduel to come

refactor: Update variable names to help make sense, update main README

c2fc0e3

feat: Add upgrade guide details

1525603

This comment was marked as outdated.

Sign in to view

chore: For upgrade path, users can use v3.5.0 of instance profile to …

4febc6c

…avoid disruption

bryantbiggs force-pushed the feat/cluster-upgrade branch from 966e5cd to 4febc6c Compare June 4, 2022 00:44

bryantbiggs marked this pull request as ready for review June 4, 2022 00:44

bryantbiggs requested a review from antonbabenko June 4, 2022 00:44

bryantbiggs commented Jun 4, 2022

View reviewed changes

outputs.tf Outdated Show resolved Hide resolved

bryantbiggs changed the title ~~feat!: Upgrade module to include capacity providers, cloudwatch log group, and minimum supported versions~~ feat!: Upgrade module to include capacity providers and bump minimum supported versions Jun 5, 2022

antonbabenko reviewed Jun 7, 2022

View reviewed changes

bryantbiggs added 2 commits June 7, 2022 08:22

chore: Update based on PR feedback

01564cb

fix: Correct links for directory rename

6d9c5a2

bryantbiggs requested a review from antonbabenko June 8, 2022 12:00

antonbabenko approved these changes Jun 8, 2022

View reviewed changes

bryantbiggs merged commit 7a41657 into terraform-aws-modules:master Jun 8, 2022

bryantbiggs deleted the feat/cluster-upgrade branch June 8, 2022 13:25

github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: Upgrade module to include capacity providers and bump minimum supported versions #60

feat!: Upgrade module to include capacity providers and bump minimum supported versions #60

bryantbiggs commented Jun 3, 2022

This comment was marked as outdated.

bryantbiggs Jun 4, 2022

bryantbiggs Jun 4, 2022 •

edited

Loading

bryantbiggs Jun 4, 2022 •

edited

Loading

antonbabenko Jun 7, 2022

bryantbiggs Jun 4, 2022

bryantbiggs Jun 4, 2022 •

edited

Loading

bryantbiggs Jun 4, 2022

antonbabenko left a comment

antonbabenko Jun 7, 2022

antonbabenko left a comment

antonbabenko commented Jun 8, 2022

github-actions bot commented Nov 8, 2022


		Configuration in this directory creates:

		- ECS cluster using Fargate (on-demand and spot) capacity provider

		@@ -0,0 +1 @@
		locals {}

feat!: Upgrade module to include capacity providers and bump minimum supported versions #60

feat!: Upgrade module to include capacity providers and bump minimum supported versions #60

Conversation

bryantbiggs commented Jun 3, 2022

Description

Motivation and Context

Breaking Changes

How Has This Been Tested?

This comment was marked as outdated.

bryantbiggs Jun 4, 2022

Choose a reason for hiding this comment

bryantbiggs Jun 4, 2022 • edited Loading

Choose a reason for hiding this comment

bryantbiggs Jun 4, 2022 • edited Loading

Choose a reason for hiding this comment

antonbabenko Jun 7, 2022

Choose a reason for hiding this comment

bryantbiggs Jun 4, 2022

Choose a reason for hiding this comment

bryantbiggs Jun 4, 2022 • edited Loading

Choose a reason for hiding this comment

bryantbiggs Jun 4, 2022

Choose a reason for hiding this comment

antonbabenko left a comment

Choose a reason for hiding this comment

antonbabenko Jun 7, 2022

Choose a reason for hiding this comment

antonbabenko left a comment

Choose a reason for hiding this comment

antonbabenko commented Jun 8, 2022

github-actions bot commented Nov 8, 2022

bryantbiggs Jun 4, 2022 •

edited

Loading

bryantbiggs Jun 4, 2022 •

edited

Loading

bryantbiggs Jun 4, 2022 •

edited

Loading