Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use lookup() on computed resource attribute lookups in for_each loop #18

Merged

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Nov 2, 2023

Description

  • Use lookup() on computed resource attribute lookups in for_each loop
  • Correct discrepancy in conditional creation logic of security group

Motivation and Context

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@@ -135,9 +135,8 @@ module "vpc" {
public_subnets = ["10.99.0.0/24", "10.99.1.0/24", "10.99.2.0/24"]
private_subnets = ["10.99.3.0/24", "10.99.4.0/24", "10.99.5.0/24"]

enable_nat_gateway = false
single_nat_gateway = true
map_public_ip_on_launch = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shaving off $$$ 👍

@bryantbiggs bryantbiggs merged commit a206e43 into terraform-aws-modules:master Nov 3, 2023
7 checks passed
@bryantbiggs bryantbiggs deleted the fix/for-each-computed branch November 3, 2023 11:34
antonbabenko pushed a commit that referenced this pull request Nov 3, 2023
### [1.3.1](v1.3.0...v1.3.1) (2023-11-03)

### Bug Fixes

* Use `lookup()` on computed resource attribute lookups in `for_each` loop ([#18](#18)) ([a206e43](a206e43))
@antonbabenko
Copy link
Member

This PR is included in version 1.3.1 🎉

Copy link

github-actions bot commented Dec 4, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants