Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid inline policy for cluster_elb_sl_role_creation? #1035

Closed
2 of 4 tasks
wlonkly opened this issue Oct 5, 2020 · 3 comments · Fixed by #1039
Closed
2 of 4 tasks

Avoid inline policy for cluster_elb_sl_role_creation? #1035

wlonkly opened this issue Oct 5, 2020 · 3 comments · Fixed by #1039

Comments

@wlonkly
Copy link
Contributor

wlonkly commented Oct 5, 2020

I'm submitting a...

  • bug report
  • feature request
  • support request - read the FAQ first!
  • kudos, thank you, warm fuzzy

What is the current behavior?

The policy attached to the cluster_elb_sl_role_creation role (here is an inline policy, which fails to apply in organizations that disable inline policies in an SCP, which is at least somewhat common.

What is the expected behavior?

This policy should be a managed policy, like all the other policies this module creates.

Are you able to fix this problem and submit a PR? Link here if you have already.

Able, yes -- but wanted to get your input before doing so.

Environment details

  • Affected module version: v12.2.0
  • OS: Mac OS 10.14.6
  • Terraform version: 0.13.4

Any other relevant info

@barryib
Copy link
Member

barryib commented Oct 5, 2020

Hello if there is a managed policy for that, I'll happy to review it.

@wlonkly
Copy link
Contributor Author

wlonkly commented Oct 6, 2020

Ah, sorry, I was imprecise -- a customer-managed policy (not AWS-managed), just not inline. PR incoming.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants