Add possibility to disable `node_groups completely

[Zyava]

I have issues

I'm submitting a...

• bug report
• feature request
• support request - read the FAQ first!
• kudos, thank you, warm fuzzy

What is the current behavior?

Currently node_groups submodule always creates a managed node group called "default" and it is not possible to disable this behaviour. However, managed group has a lot of missing features which is possible to enable/configure via worker_groups_launch_template:

• Add support for userdata in managed NodeGroups #1192
• Example: Add the SPOT support for Managed Node Groups (#1129) #1206
• Managed Node Groups with Launch Template using Spot Instances: Taints #1214
• When using NodeGroups, we should be able to choose the ASG name prefix #1215
• How to keep a node_group with size = 0 #1233

It should be possible to disable `node_groups completely.

If this is a bug, how to reproduce? Please include a code sample if relevant.

What's the expected behavior?

node_groups can be disabled completely and worker_groups_launch_template used instead.

Are you able to fix this problem and submit a PR? Link here if you have already.

PR: #1291

Environment details

• Affected module version:
• OS:
• Terraform version:

Any other relevant info

[barryib]

I don't really understand your need. Where that "default" node group coming from ?

[Zyava]

@barryib did you even check my PR? If yes, you couldn't miss the only functional change I made...

[barryib]

@barryib did you even check my PR? If yes, you couldn't miss the only functional change I made...

I saw that, but to me we only create resources if var.node_groups is not empty and var.create_eks is true https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/modules/node_groups/locals.tf#L3.

Unless you want to define something in var.node_groups and still disable node group creation ?

[Zyava]

You are now referring to the line which was added on 19th of April while my issue and PR was created on 31st of March and ask questions which I can't answer. I didn't follow the module source code changes after I created my PR, sorry.

I don't know why my PR was ignored for 2 months and now you ask these questions.
If this issue and PR are obsolete now - feel free to close it.

[barryib]

You are now referring to the line which was added on 19th of April while my issue and PR was created on 31st of March and ask questions which I can't answer. I didn't follow the module source code changes after I created my PR, sorry.

@Zyava that line exist since January 2020. See the submodule init PR #650

My question was simple: What is your needs and where that "default" you were mentioning coming from ?

I don't know why my PR was ignored for 2 months and now you ask these questions.

This is community module, I'm not working alone on this. So probably someone may answer your question.

FIW, I was not available for personal matters. I work on this on personal time during long nights... So feel free to sponsor terraform-aws-modules to get the SLA you need.

I'm closing this, since we won't get anything good from our discussions.

Regards.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.