Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set custom timeouts for create and delete in fargate_profiles input #1610

Closed
IvanDechovsky opened this issue Sep 30, 2021 · 7 comments
Closed

Comments

@IvanDechovsky
Copy link
Contributor

Is your request related to a new offering from AWS?

No

Is your request related to a problem? Please describe.

When creating/destroying fargate profiles we often hit the 10 minute default timeout limit causing the terraform apply to fail.

Describe the solution you'd like.

The aws_eks_fargate_profile resource has the ability to define a different timeout for create | delete. We would like to be able to set those via the fargate_profiles input in the module

@daroga0002
Copy link
Contributor

we should address this issue in same way as in node groups:

timeouts {
create = lookup(each.value["timeouts"], "create", null)
update = lookup(each.value["timeouts"], "update", null)
delete = lookup(each.value["timeouts"], "delete", null)
}

to make a consistent user experience.

@daroga0002
Copy link
Contributor

@IvanDechovsky do you will be able to submit PR for this?

@IvanDechovsky
Copy link
Contributor Author

#1614

@daroga0002 daroga0002 added the wip label Oct 1, 2021
@IvanDechovsky
Copy link
Contributor Author

@daroga0002 PR updated. Slightly different approach where the same timeouts are applied across all profiles. Tested as well. Thanks for the feedback.

@stale
Copy link

stale bot commented Nov 1, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 1, 2021
@daroga0002 daroga0002 removed the stale label Nov 2, 2021
@daroga0002
Copy link
Contributor

#1614 was merged so closing this issue, it will be in next release

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants