fix: Correct DNS suffix for OIDC provider #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you @xchan - can you update your PR title to something like |
bryantbiggs
changed the title
antonbabenko
pushed a commit
that referenced
this pull request
Apr 20, 2022
### [18.20.4](v18.20.3...v18.20.4) (2022-04-20) ### Bug Fixes * Correct DNS suffix for OIDC provider ([#2026](#2026)) ([5da692d](5da692d))
|
This PR is included in version 18.20.4 🎉 |
spr-mweber3
pushed a commit
to spring-media/terraform-aws-eks
that referenced
this pull request
Apr 26, 2022
Co-authored-by: Xin Chen <chenxin@konvery.com> Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
spr-mweber3
pushed a commit
to spring-media/terraform-aws-eks
that referenced
this pull request
Apr 26, 2022
### [18.20.4](terraform-aws-modules/terraform-aws-eks@v18.20.3...v18.20.4) (2022-04-20) ### Bug Fixes * Correct DNS suffix for OIDC provider ([terraform-aws-modules#2026](terraform-aws-modules#2026)) ([5da692d](terraform-aws-modules@5da692d))
it-without-politics
pushed a commit
to it-without-politics/terraform-aws-eks
that referenced
this pull request
May 23, 2022
Co-authored-by: Xin Chen <chenxin@konvery.com> Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
it-without-politics
pushed a commit
to it-without-politics/terraform-aws-eks
that referenced
this pull request
May 23, 2022
### [18.20.4](terraform-aws-modules/terraform-aws-eks@v18.20.3...v18.20.4) (2022-04-20) ### Bug Fixes * Correct DNS suffix for OIDC provider ([terraform-aws-modules#2026](terraform-aws-modules#2026)) ([5da692d](terraform-aws-modules@5da692d))
baibailiha
added a commit
to baibailiha/terraform-aws-eks
that referenced
this pull request
Sep 13, 2022
### [18.20.4](terraform-aws-modules/terraform-aws-eks@v18.20.3...v18.20.4) (2022-04-20) ### Bug Fixes * Correct DNS suffix for OIDC provider ([#2026](terraform-aws-modules/terraform-aws-eks#2026)) ([136fccf](terraform-aws-modules/terraform-aws-eks@136fccf))
|
I try to migrate cluster from v17.24.0 to v18.29.0 and faced with deployment to AWS China, that error appears: Fixed by adding variable so looks like in China we have the same principal - "eks.amazonaws.com", but not "eks.amazonaws.com.cn" as currently module tried to create |
3 tasks
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a supplement fix for
#1904
Motivation and Context
This MR is a combined fix for succefully launching Karpenter 0.8.2 on AWS EKS on China Region (cn-northwest-1)
Breaking Changes
N/A
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull requestAWS EKS version 1.22 + Karpenter 0.8.2 launched succefully with this fix with node scaling test done.