fix: Remove modified_at from ignored changes on EKS addons
#2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
antonbabenko
approved these changes
Jun 19, 2022
antonbabenko
pushed a commit
that referenced
this pull request
Jun 19, 2022
### [18.24.1](v18.24.0...v18.24.1) (2022-06-19) ### Bug Fixes * Remove `modified_at` from ignored changes on EKS addons ([#2114](#2114)) ([5a5a32e](5a5a32e))
|
This PR is included in version 18.24.1 🎉 |
|
yep, the warning is gone now, and everything else seems to work fine as expected. thanks much! |
1 task
spr-mweber3
pushed a commit
to spring-media/terraform-aws-eks
that referenced
this pull request
Jul 11, 2022
spr-mweber3
pushed a commit
to spring-media/terraform-aws-eks
that referenced
this pull request
Jul 11, 2022
### [18.24.1](terraform-aws-modules/terraform-aws-eks@v18.24.0...v18.24.1) (2022-06-19) ### Bug Fixes * Remove `modified_at` from ignored changes on EKS addons ([terraform-aws-modules#2114](terraform-aws-modules#2114)) ([5a5a32e](terraform-aws-modules@5a5a32e))
3 tasks
baibailiha
added a commit
to baibailiha/terraform-aws-eks
that referenced
this pull request
Sep 13, 2022
### [18.24.1](terraform-aws-modules/terraform-aws-eks@v18.24.0...v18.24.1) (2022-06-19) ### Bug Fixes * Remove `modified_at` from ignored changes on EKS addons ([#2114](terraform-aws-modules/terraform-aws-eks#2114)) ([4f8dd86](terraform-aws-modules/terraform-aws-eks@4f8dd86))
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
modified_atfrom ignored changes on EKS addonsMotivation and Context
completeexample using version 1.1.5 I am not seeing the changes in the plans as before. However, while forcing a minimum required version of 1.2.0 would be a breaking change, simply removing the ignored changes is not a breaking change. Either route (keep the ignored changes or remove) has the potential to show something in the plans/applies so why not remove it in favor of using the later versions of Terraform which doesn't incur a breaking change penaltyBreaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request