Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use partition data source on VPC CNI IPv6 policy #2161

Merged
merged 3 commits into from
Jul 20, 2022

Conversation

ilunam
Copy link
Contributor

@ilunam ilunam commented Jul 19, 2022

Description
Minor fix allowing partition changes as per main.tf.

Motivation and Context
Failed when using a different partition.

Breaking Changes
No.

How Has This Been Tested?
Unsure how to test it in example context. Require differing partitions.

Corrected to match suggestion from previous PR. I've run the code against my scenario and it worked fine.

@bryantbiggs bryantbiggs changed the title fix: Minor fix allowing partition changes as per main.tf fix: Use partition data source on VPC CNI IPv6 policy Jul 20, 2022
@bryantbiggs bryantbiggs merged commit f2d67ff into terraform-aws-modules:master Jul 20, 2022
antonbabenko pushed a commit that referenced this pull request Jul 20, 2022
### [18.26.4](v18.26.3...v18.26.4) (2022-07-20)

### Bug Fixes

* Use partition data source on VPC CNI IPv6 policy ([#2161](#2161)) ([f2d67ff](f2d67ff))
@antonbabenko
Copy link
Member

This PR is included in version 18.26.4 🎉

@ilunam ilunam deleted the ilunam/partition-fix branch July 21, 2022 23:35
spr-mweber3 pushed a commit to spring-media/terraform-aws-eks that referenced this pull request Jul 22, 2022
spr-mweber3 pushed a commit to spring-media/terraform-aws-eks that referenced this pull request Jul 22, 2022
baibailiha added a commit to baibailiha/terraform-aws-eks that referenced this pull request Sep 13, 2022
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants