feat: Add support for allowed_instance_type #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petros-d
changed the title
petros-d
changed the title
|
thank you! could we also add |
|
Good idea; I've added I didn't see any examples using the |
antonbabenko
pushed a commit
that referenced
this pull request
Apr 12, 2023
## [19.13.0](v19.12.0...v19.13.0) (2023-04-12) ### Features * Add support for allowed_instance_type ([#2552](#2552)) ([54417d2](54417d2))
|
This PR is included in version 19.13.0 🎉 |
1 task
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for the
allowed_instance_typesparameter in theinstance_requirementsblock of the self managed nodegroups ASG.Motivation and Context
This allowed additional flexibility when configuring the ASGs to use specific instance types. By defining the list of allowed instance types, we allow a more deterministic way of configuring our environment. Support for
allowed_instance_typeswas added inv4.57.0of the aws provider, so have bumped up the version: https://github.com/hashicorp/terraform-provider-aws/releases/tag/v4.57.0Breaking Changes
No expected breaking changes