support EKS logs

[confiq]

I'm submitting a...

• bug report
• feature request
• support request
• kudos, thank you, warm fuzzy

What is the current behavior?

We depend on the issue 8204, but when that is implemented, we can configure logs for EKS.

What's the expected behavior?

Are you able to fix this problem and submit a PR? Link here if you have already.

Not yet

Environment details

Terraform v0.11.13

• provider.aws v2.4.0 <- can't work with this
• provider.kubernetes v1.5.2
• provider.local v1.1.0
• provider.null v2.1.0
• provider.template v1.0.0

Any other relevant info

At the moment, we don't have requirements for AWS provider (correct me if I'm mistaken) but right now this module can't work with >v2.2 anyway (cluster_endpoints).
EDIT: Any suggestions on how to make provider aws version as a requirement?

[chenrui333]

it has been released as provider v2.6.0 :)

[max-rocket-internet]

And merged. Please test and I'll make a release soon.

[chenrui333]

Sure, I will do a quick check on this today.

[chenrui333]

BTW, if we want to release, we need to update the provider version in here too:
https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/examples/eks_test_fixture/main.tf#L6

[confiq]

#347

I'm closing this issue

[chenrui333]

I forgot to update here, I have run with aws provider 2.6.0 for last weekend without any issue.

[chenrui333]

@max-rocket-internet I think we do need to enforce the provider version with the new feature of eks logs.

[confiq]

@chenrui333 the question is how? according to the https://github.com/terraform-aws-modules/terraform-aws-eks/pull/347/files , we only update example how to use the module

[chenrui333]

yeah, indeed, I was think of enforcing the module version in the module level.

You might be interested with this issue I submitted, hashicorp/terraform#20996

[max-rocket-internet]

I think we do need to enforce the provider version with the new feature of eks logs.

Indeed. I'm not sure how though. I think in the past we had providers defined inside the module itself but then TF community moved away from this I think?

[max-rocket-internet]

Already had a issue for this: #348

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.