improvement: Add timeout to default wait_for_cluster_cmd

[dpiddockcmp]

PR o'clock

Description

The current default command for wait_for_cluster will happily sit forever in a failing state. Module previously had a timeout before the switch to kubernetes provider in 8.0.0.

Defaults to 5 minutes of sleeps. May be a lot longer depending on how wget hangs.

Have tested logic on bash 3 (for those older Mac users), zsh, bash 5, and busybox (default in alpine)

$ docker run --rm -it alpine /bin/sh -c 'for i in `seq 1 60`; do false && exit 0 || true; sleep 0; done; echo TIMEOUT && exit 1' ; echo $?
TIMEOUT
1
$ docker run --rm -it alpine /bin/sh -c 'for i in `seq 1 60`; do true && exit 0 || true; sleep 0; done; echo TIMEOUT && exit 1' ; echo $?
0

Sample failure output (I lowered the seq count because ain't got all day):

module.eks.null_resource.wait_for_cluster[0]: Creating...
module.eks.null_resource.wait_for_cluster[0]: Provisioning with 'local-exec'...
module.eks.null_resource.wait_for_cluster[0] (local-exec): Executing: ["/bin/sh" "-c" "for i in `seq 1 2`; do wget --no-check-certificate -O - -q $ENDPOINT/healthz >/dev/null && exit 0 || true; sleep 5; done; echo TIMEOUT && exit 1"]
module.eks.null_resource.wait_for_cluster[0]: Still creating... [10s elapsed]
module.eks.null_resource.wait_for_cluster[0] (local-exec): TIMEOUT


Error: Error running command 'for i in `seq 1 2`; do wget --no-check-certificate -O - -q $ENDPOINT/healthz >/dev/null && exit 0 || true; sleep 5; done; echo TIMEOUT && exit 1': exit status 1. Output: TIMEOUT

I don't think there are any issues directly about this but it would have helped the user in #777 for example. Or at least wasted slightly less time watching paint dry 🙂

Checklist

• CI tests are passing
• README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.