feat: Add interpreter option to wait_for_cluster_cmd

[avoidik]

PR o'clock

Description

Allow to configure interpreter item for the wait_for_cluster_cmd command. Potential improvement into compatibility with Windows

#680

Checklist

• Change added to CHANGELOG.md. All changes must be added and breaking changes and highlighted
• CI tests are passing
• README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[avoidik]

rel.
#639
#701

[avoidik]

module "eks" {
  source  = "terraform-aws-modules/eks/aws"
  # windows workaround
  wait_for_cluster_interpreter = ["c:/git/bin/sh.exe", "-c"]
  wait_for_cluster_cmd         = "until curl -sk $ENDPOINT >/dev/null; do sleep 4; done"
}

[amitsehgal]

@barryib can this variable be added at node group, worker group level and not at cluster level ?

[Type1J]

Doesn't this break Linux nodes?

[avoidik]

@Type1J it is optional parameter, if not specified safe defaults will be used instead

[Type1J]

I meant in the same cluster. I haven't tried it, but as @amitsehgal implied, the worker group could be Linux or Windows, and since this is specified at the module level, it seems that this parameter would affect both worker groups, so only 1 worker group would have the correct interpreter. Again, I haven't tried it, yet. I'm evaluating this module for use in a mixed (Linux and Windows) EKS cluster, so I'd like to understand it.

[avoidik]

@Type1J not sure how it supposed to affect individual worker groups, the command being executed locally to confirm k8s api readiness

[Type1J]

Oh. Thanks for the clarification.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.