-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add IAM permissions for ELB svc-linked role creation by EKS cluster #902
feat: Add IAM permissions for ELB svc-linked role creation by EKS cluster #902
Conversation
713c9c1
to
27c9e45
Compare
cluster.tf
Outdated
|
||
statement { | ||
effect = "Allow" | ||
actions = ["ec2:DescribeAccountAttributes"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
Ran into this same issue, and ended up needing ec2:DescribeInternetGateways
in addition to the above IAM access action.
Thanks for the fix. 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi James,
Thank you for the suggestion regarding ec2:DescribeInternetGateways
permissions that must be attached to the IAM role as well.
27c9e45
to
8317af9
Compare
AmazonEKSClusterPolicy IAM policy doesn't contain all necessary permissions to create ELB service-linked role required during LB provisioning at AWS by K8S Service. terraform-aws-modules#900 terraform-aws-modules#183 (comment)
8317af9
to
f2842da
Compare
We also encounter the same issue, would be cool if this can be merged |
@dpiddockcmp can you please review this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multiple people confirmed the issue exists and that this is the fix.
Looking through CloudTrail this change at least makes first creation of LBs a lot faster, as kubernetes only needs to attempt it once. Before the change it took 3 attempts in a sample account which had the service account deleted.
@barryib @dpiddockcmp Thank you guys |
…ster (terraform-aws-modules#902) AmazonEKSClusterPolicy IAM policy doesn't contain all necessary permissions to create ELB service-linked role required during LB provisioning at AWS by K8S Service. terraform-aws-modules#900 terraform-aws-modules#183 (comment)
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
PR o'clock
Description
AmazonEKSClusterPolicy IAM policy doesn't contain all necessary permissions to create ELB service-linked role required during LB provisioning at AWS by K8S Service.
#900
Checklist