feat: Ensure that GitHub OIDC subject prefixes are normalied for repo:
#310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonbabenko
approved these changes
Nov 21, 2022
Co-authored-by: Anton Babenko <anton@antonbabenko.com>
antonbabenko
pushed a commit
that referenced
this pull request
Nov 21, 2022
## [5.7.0](v5.6.0...v5.7.0) (2022-11-21) ### Features * Ensure that GitHub OIDC subject prefixes are normalied for `repo:` ([#310](#310)) ([b9873a0](b9873a0))
|
This PR is included in version 5.7.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
repo:Motivation and Context
subjectsused in theiam-github-oidc-rolewill need to start withrepo:so the code originally added that for users. However, nearly all documentation shows the subject withrepo:...and users add this text into their subjects. This results in subjects that then look likerepo:repo:...which is incorrect. This change normalizes the text to ensure that subjects only start withrepo:...regardless of whether the user adds it or not in their provided subjectsBreaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request