fix: Reflect the changes in the ebs_csi driver #326
Conversation
prysmakou-sa
changed the title
prysmakou-sa
changed the title
prysmakou-sa
changed the title
|
so the change looks great - makes sense. However, for users who are using versions < 2.14.1, this will break their permissions - *I think. So we'll need to somehow factor that into the change - I don't know if the CSI drivers still support the old route with the cluster owned, open to ideas though |
|
@bryantbiggs just to be on the safe side we could let loose the permissions for a while: to save the current/former statement and add the new one. I mean not to replace the condition but to add an additional one. What do you think? |
Instead of replacing the condition we add new to support (for a while) users of older versions of the EBS driver.
prysmakou-sa
force-pushed
the
fix/ebs-driver
branch
from
f537d1c to
53cd87c
Compare
|
I have updated the PR so now we do not replace the condition but add the new statement. |
### [5.11.1](v5.11.0...v5.11.1) (2023-01-19) ### Bug Fixes * Reflect the changes in the ebs_csi driver ([#326](#326)) ([cadfe47](cadfe47))
|
This PR is included in version 5.11.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
modules/iam-role-for-service-accounts-eks -
EBS-CSI driver policy - fix condition string for DeleteVolume action to reflect the changes in the upstream
Motivation and Context
Issue - #325
The change in the upstream - kubernetes-sigs/aws-ebs-csi-driver#1450
Breaking Changes
There are no breaking changes
How Has This Been Tested?
pre-commit run -aon my pull request