Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add path variable to IAM group module #390

Merged
merged 4 commits into from
Jun 29, 2023

Conversation

chasleslr
Copy link
Contributor

Description

This adds the variable path to iam-group-with-policies.

Motivation and Context

This was seemingly left out as an oversight since iam-group-with-assumable-roles-policy does include path as a variable.

Breaking Changes

N/A

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@chasleslr chasleslr changed the title Add path in iam-group-with-policies fix(iam-group-with-policies): add missing path variable Jun 13, 2023
@chasleslr chasleslr changed the title fix(iam-group-with-policies): add missing path variable fix(iam-group-with-policies): Add missing path variable Jun 13, 2023
@bryantbiggs bryantbiggs changed the title fix(iam-group-with-policies): Add missing path variable feat: Add path variable to IAM group module Jun 29, 2023
@bryantbiggs bryantbiggs merged commit e5c42c3 into terraform-aws-modules:master Jun 29, 2023
antonbabenko pushed a commit that referenced this pull request Jun 29, 2023
## [5.24.0](v5.23.1...v5.24.0) (2023-06-29)

### Features

* Add `path` variable to IAM group module ([#390](#390)) ([e5c42c3](e5c42c3))
@antonbabenko
Copy link
Member

This PR is included in version 5.24.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants