-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added variable trusted_role_actions to sub modules as a "Action of STS" #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharewicz
changed the title
feat: added variable trusted_role_actions to sub modules as a Extra action of STS
feat: Added variable trusted_role_actions to sub modules as a Extra action of STS
Jun 20, 2023
bryantbiggs
requested changes
Jun 20, 2023
tcharewicz
changed the title
feat: Added variable trusted_role_actions to sub modules as a Extra action of STS
feat: Added variable trusted_role_actions to sub modules as a "Action of STS"
Jun 27, 2023
bryantbiggs
approved these changes
Jun 29, 2023
antonbabenko
pushed a commit
that referenced
this pull request
Jun 29, 2023
## [5.23.0](v5.22.0...v5.23.0) (2023-06-29) ### Features * Added variable trusted_role_actions to sub modules as a "Action of STS" ([#393](#393)) ([5702679](5702679))
This PR is included in version 5.23.0 🎉 |
@bryantbiggs Thx. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Orginaly I create issue with "Adding variable trusted_role_actions to other sub-modules"
- iam-assumable-roles
- iam-assumable-role-with-saml
- iam-assumable-roles-with-saml
At the time of PR creation I found that, in sub module iam-assumable-role-with-saml this variable is used, but in different way comparing to sub module iam-assumable-role.
In module with iam-assumable-role-with-saml is used as a "Extra Actions of STS"
In module with iam-assumable-role is used as a "Actions of STS"
That way finally PR is adding this variable as a "Extra Actions of STS" to sub modules:
Motivation and Context
It's useful to use two additional action with STS action:
But when you want to use them, you need to add them to all roles in AWS Account.
Breaking Changes
None, all orginal default action are preserved.
How Has This Been Tested?
pre-commit run -a
on my pull request