feat: Github OIDC add extra thumbprints as needed #403
Conversation
examples/iam-github-oidc/main.tf
Outdated
| @@ -21,6 +21,12 @@ locals { | |||
| module "iam_github_oidc_provider" { | |||
| source = "../../modules/iam-github-oidc-provider" | |||
|
|
|||
| # https://github.blog/changelog/2023-06-27-github-actions-update-on-oidc-integration-with-aws/ | |||
| additional_thumbprint_list = [ | |||
There was a problem hiding this comment.
Instead of putting these values in the examples, we would rather have them as defaults, so users should just upgrade the version of the module and use it right away.
/cc @bryantbiggs WDYT?
There was a problem hiding this comment.
ya we can try that. I've checked internally as well and there isn't a clear path to resolution so lets try and see what happens
## [5.26.0](v5.25.0...v5.26.0) (2023-07-03) ### Features * Github OIDC add extra thumbprints as needed ([#403](#403)) ([56511f3](56511f3))
|
This PR is included in version 5.26.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Add additional thumbprint list as needed.
Motivation and Context
Breaking Changes
No.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request