Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AWS Lambda URLs #306

Closed
diy-eng opened this issue Apr 21, 2022 · 5 comments · Fixed by #308
Closed

Support AWS Lambda URLs #306

diy-eng opened this issue Apr 21, 2022 · 5 comments · Fixed by #308

Comments

@diy-eng
Copy link

diy-eng commented Apr 21, 2022

Is your request related to a new offering from AWS?

Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

  • Yes ✅: please list the AWS provider version which introduced this functionality
  • v4.9.0
  • Issue

Is your request related to a problem? Please describe.

The module does not support (AWS Lambda URLs)[https://docs.aws.amazon.com/lambda/latest/dg/lambda-urls.html]

Describe the solution you'd like.

The module will support AWS Lambda URLs.

Describe alternatives you've considered.

Workaround: Use terraform native support.

Additional context

@diy-eng
Copy link
Author

diy-eng commented Apr 21, 2022

Workaround
{CODE REMOVED}

@antonbabenko
Copy link
Member

This workaround is unnecessary because there is already native support for this resource in the Terraform AWS provider. We need to add it to the module, so PR is welcome.

@diy-eng
Copy link
Author

diy-eng commented Apr 22, 2022

This workaround is unnecessary because there is already native support for this resource in the Terraform AWS provider. We need to add it to the module, so PR is welcome.

@antonbabenko Good call. I redacted the code & will try using using native support.

Will make some time to research if I can make PR, have not created/modified a module before.

@antonbabenko
Copy link
Member

This issue has been resolved in version 3.2.0 🎉

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants