fix: Always use absolute path to temp folders #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sassdavid
changed the title
sassdavid
force-pushed
the
improvement/tempdir
branch
from
6b0c184
to
27585a5
Compare
sassdavid
force-pushed
the
improvement/tempdir
branch
from
27585a5
to
89d980d
Compare
sassdavid
changed the title
antonbabenko
approved these changes
Jul 25, 2024
antonbabenko
merged commit a058372
into
terraform-aws-modules:master
30 of 31 checks passed
antonbabenko
pushed a commit
that referenced
this pull request
Jul 25, 2024
## [7.7.1](v7.7.0...v7.7.1) (2024-07-25) ### Bug Fixes * Always use absolute path to temp folders ([#599](#599)) ([a058372](a058372))
|
This PR is included in version 7.7.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #592.
Since Python 3.12 changed the default behavior of
tempfile.mkdtemp(suffix=None, prefix=None, dir=None)(see the documentation here) and based on the discussion in the issue, it is recommended to use absolute paths for temporary folders. This pull request addresses that for earlier Python versions.From now on, the method in the package.py will return an absolute path.
Motivation and Context
The details are described in issue #592.
Breaking Changes
Since this is the proposed solution and all the examples use absolute paths for the temporary folders, it is presumably not a breaking change.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request