Skip to content

feat: Support passing extra args to pip install #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

feat: Support passing extra args to pip install #655

wants to merge 6 commits into from

Conversation

LironEr
Copy link

@LironEr LironEr commented Jan 17, 2025

Description

Added support to pass extra arguments to pip install command

{
  path                   = "src/python-app1",
  pip_requirements       = true,
  pip_install_extra_args = ["--platform", "manylinux2014_aarch64", "--only-binary", ":all:"]
}

Motivation and Context

Due to limitations with our CI, we can't use docker when installing and zipping requirements.
To overcome this we use the platform flag when running pip install to download the right distribution per lambda architecture.

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects

I have tested these changes locally and deployed a lambda to AWS. I am happy to do additional testing if necessary.

  • I have executed pre-commit run -a on my pull request

@github-actions GitHub Actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Feb 27, 2025
@LironEr
Copy link
Author

LironEr commented Feb 27, 2025

Please review 🙏

@github-actions github-actions bot removed the stale label Feb 28, 2025
@Ron-Be
Copy link

Ron-Be commented Mar 11, 2025

This is a needed improvement, please review

@shira-lev
Copy link

please review 🙏

@github-actions GitHub Actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Apr 11, 2025
@LironEr
Copy link
Author

LironEr commented Apr 11, 2025

@antonbabenko please review 🙏

@github-actions github-actions bot removed the stale label Apr 12, 2025
@pawelpesz
Copy link
Contributor

I have another use case for this, in order to be able to use packages published in a Gemfury repository, the following extra pip argument is needed:

pip install py-sample --extra-index-url <Repo-URL>

See: https://gemfury.com/help/pypi-server/

@RonBeny
Copy link

RonBeny commented Apr 22, 2025

Hi @antonbabenko is there any update on this? Thanks

az-wegift
az-wegift reviewed May 21, 2025
View reviewed changes
Copy link

@az-wegift az-wegift left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes overall look good, but we are missing the examples update.

@github-actions GitHub Actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Jun 21, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2025

This PR was automatically closed because of stale in 10 days

@github-actions github-actions bot closed this Jul 1, 2025
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@az-wegift az-wegift az-wegift left review comments

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LironEr @Ron-Be @shira-lev @pawelpesz @RonBeny @az-wegift