feat!: Add support for data tiering attribute, bump minimum supported versions of Terraform and AWS provider #5
Conversation
typat
changed the title
versions.tf
Outdated
| @@ -4,7 +4,7 @@ terraform { | |||
| required_providers { | |||
| aws = { | |||
| source = "hashicorp/aws" | |||
| version = ">= 3.71" | |||
| version = ">= 4.42.0" | |||
There was a problem hiding this comment.
Since this is now a breaking change, lets just go all the way up to v5.0 of the AWS provider
Also, lets move the min required version of Terraform up to 1.0
There was a problem hiding this comment.
ah missed your second comment
examples/data-tiering/main.tf
Outdated
| node_type = "db.r6gd.xlarge" | ||
| num_shards = 2 | ||
| num_replicas_per_shard = 2 | ||
| data_tiering = true |
There was a problem hiding this comment.
we can add this to the existing example - no need for a whole new example just for this
There was a problem hiding this comment.
perfect. i debated this but wasnt sure
bryantbiggs
changed the title
## [2.0.0](v1.1.2...v2.0.0) (2023-08-11) ### ⚠ BREAKING CHANGES * Add support for data tiering attribute, bump minimum supported versions of Terraform and AWS provider (#5) ### Features * Add support for data tiering attribute, bump minimum supported versions of Terraform and AWS provider ([#5](#5)) ([1c94464](1c94464))
|
This PR is included in version 2.0.0 🎉 |
|
thanks for the quick feedback! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Without the ability to set the data tiering parameter during cluster creation, data tiering node types are not able to be used. The data tiering attribute is supported by the AWS provider since v4.42.0
VPC version was updated to 4 to get validate passing due to enable_classiclink being removed in AWS Provider 5.0.0.
Motivation and Context
This change allows the use of data tiering node groups and supports hashicorp/terraform-provider-aws#28022.
Breaking Changes
Yes, lots of breaking changes due to major version increase in AWS provider.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request