Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added path input variable for lambda module IAM role #150

Merged
merged 4 commits into from
Dec 9, 2021
Merged

feat: Added path input variable for lambda module IAM role #150

merged 4 commits into from
Dec 9, 2021

Conversation

onymbuk
Copy link
Contributor

@onymbuk onymbuk commented Dec 8, 2021

Description

Role path is needed for IAM role created by lambda module

Motivation and Context

We use permission boundaries tied to IAM role path in our environment. This is required for us

Breaking Changes

No breaking change

How Has This Been Tested?

This has been tested on this branch

@bryantbiggs
Copy link
Member

thanks @onymbuk - are you able to update the docs by running pre-commit run -a?

@onymbuk onymbuk changed the title Patch 1 Adding path input variable for lambda module IAM role Dec 9, 2021
@onymbuk
Copy link
Contributor Author

onymbuk commented Dec 9, 2021 •
edited
Loading

Docs now updated

@onymbuk onymbuk closed this Dec 9, 2021
@onymbuk onymbuk reopened this Dec 9, 2021
bryantbiggs
bryantbiggs approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonbabenko 👍

@antonbabenko antonbabenko changed the title Adding path input variable for lambda module IAM role feat: Added path input variable for lambda module IAM role Dec 9, 2021
@antonbabenko antonbabenko merged commit fc0c120 into terraform-aws-modules:master Dec 9, 2021
antonbabenko pushed a commit that referenced this pull request Dec 9, 2021
@semantic-release-bot
chore(release): version 4.19.0 [skip ci]
6b7db5d 
# [4.19.0](v4.18.0...v4.19.0) (2021-12-09)

### Bug Fixes

* update CI/CD process to enable auto-release workflow ([#149](#149)) ([f7dd0a3](f7dd0a3))

### Features

* Added path input variable for lambda module IAM role ([#150](#150)) ([fc0c120](fc0c120))
@antonbabenko
Copy link
Member

This PR is included in version 4.19.0 🎉

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onymbuk @bryantbiggs @antonbabenko