feat: Add ephemeral_storage_size variable #167
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using this module in GovCloud, we get this error (this is sanitized):
This was fixed in 3.1.1 of terraform-aws-lambda: terraform-aws-modules/terraform-aws-lambda#304 (comment)
This PR does two things:
When adding the new variable, I followed the naming scheme I observed here (e.g.:
lambda_function_variable_name_from_submodule
):terraform-aws-notify-slack/variables.tf
Lines 135 to 163 in 1d7bfe9
I copied the description, type, and default from here: https://github.com/terraform-aws-modules/terraform-aws-lambda/blob/19b9f11fc8ed04a34c02db553d3f463cab6b740a/variables.tf#L112-L116
Motivation and Context
Without this change, using this module in GovCloud results in this error:
This is the same issue described here: terraform-aws-modules/terraform-aws-lambda#304
Breaking Changes
This does not break backward compatibility. The default in this module (512) is the same as the default used by the terraform-aws-lambda module (512).
How Has This Been Tested?
pre-commit run -a
on my pull requestterraform apply
with it in GovCloud. The error no longer occurs when I setlambda_function_ephemeral_storage_size
tonull
.