Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add S3 import functionality which is supported for MySQL instances #197

Merged

Conversation

bryantbiggs
Copy link
Member

Description

  • add S3 import functionality which is supported for MySQL instances
  • add new example for demonstrating and verifying S3 import functionality

this closely mirrors what was implemented at terraform-aws-modules/terraform-aws-rds#289

Closes #126

Motivation and Context

  • adds functionality to import Percona Xtrabackup from S3

Breaking Changes

  • No

How Has This Been Tested?

  • Tested using examples/s3_import module that was added

@bryantbiggs bryantbiggs requested a review from antonbabenko March 2, 2021 03:57
@antonbabenko antonbabenko merged commit afba0a7 into terraform-aws-modules:master Mar 2, 2021
@antonbabenko
Copy link
Member

Thanks @bryantbiggs !

The only thing is that I am not sure we really need 3,4MB zip in this repo which everyone should download now even if they don't use this feature. If people will complain about it we probably need to reduce this file size to the minimum required for example.

v3.7.0 has been just released.

@bryantbiggs
Copy link
Member Author

ya, I'm not a MySQL expert so I wasn't sure if there were things that could be trimmed from the database dump

lsc added a commit to qapital/terraform-aws-rds-aurora that referenced this pull request Apr 27, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants