Add security group name and description #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to prevent errors like
Error: Invalid index
on ../../modules/aws-rds-aurora/main.tf line 4, in locals:
4: db_subnet_group_name = var.db_subnet_group_name == "" ?
aws_db_subnet_group.this[0].name : var.db_subnet_group_name
|----------------
| aws_db_subnet_group.this is empty tuple
when calling import with this module in the configuration.
|
Thanks, Miguel! v2.10.0 has been just released. |
Closed
akofman
added a commit
to akofman/terraform-aws-rds-aurora
that referenced
this pull request
Apr 10, 2020
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds name (tag) and description attributes to the security group and its rules.
In addition, to prevent errors when (for example) importing resources with this module present in the configuration, this PR also replaces the hard-coded access to index 0 of conditional resources by a call to
joinfunction using the splat notation.An example of the error I was getting while importing resources form other modules, while having this module in my terraform config: