Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove default values and replace with null to use upstream default settings #315

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Mar 15, 2021

Description

  • remove default values and replace with null to use upstream default settings

Motivation and Context

  • the default values provided by the AWS provider/API will change periodically. instead of hard-coding those values in this module as the module default values, switching to null will allow the module to be flexible and change with the upstream source as needed

Closes #235
Closes #273

Breaking Changes

  • No

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
  • tested using complete-postgresql - no diff change between master and this PR

@antonbabenko antonbabenko merged commit a96ca10 into terraform-aws-modules:master Mar 15, 2021
@antonbabenko
Copy link
Member

v2.30.0 has been just released.

@bryantbiggs bryantbiggs deleted the chore/use-upstream-defaults branch March 15, 2021 12:21
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres: apply fails due to use of Oracle character_set_name RDS db_instance storage type default
2 participants