MSSQL: Adding two missing arguments for aws_db_instance: timezone & character_set_name #51
Conversation
There was a problem hiding this comment.
This is the main reason why this module didn't have support for MSSQL:
1 error(s) occurred:
* module.db.module.db_instance.aws_db_instance.this: 1 error(s) occurred:
* aws_db_instance.this: Error creating DB Instance: InvalidParameterCombination: You can't specify a time zone when you create a DB instance running mysql.
status code: 400, request id: be0591d3-f240-46b7-8528-184412c1a342
The workaround is to create another resource aws_db_instance with these values when creating mssql and change outputs to be conditional.
main.tf
Outdated
| @@ -88,4 +88,7 @@ module "db_instance" { | |||
| create_monitoring_role = "${var.create_monitoring_role}" | |||
|
|
|||
| tags = "${var.tags}" | |||
antonbabenko
changed the title
|
@antonbabenko good point, I didn't think about that. I took a stab at having the separate db_instance and having conditional outputs. Both mssql and mysql seem to work now. Let me know anything else that needs changed. |
| @@ -63,4 +67,57 @@ resource "aws_db_instance" "this" { | |||
| backup_window = "${var.backup_window}" | |||
|
|
|||
| tags = "${merge(var.tags, map("Name", format("%s", var.identifier)))}" | |||
|
|
|||
| character_set_name = "${var.character_set_name}" | |||
There was a problem hiding this comment.
Isn't character_set_name also supported in mssql?
There was a problem hiding this comment.
@antonbabenko actually looking at the docs, character_set_name only applies to Oracle instances. I'll go ahead and remove this line.
There was a problem hiding this comment.
Well never mind actually. It doesn't break deploying like timezone does, so it seems safe to leave it in.
|
Great work @aloisbarreras ! This PR has been released as part of v1.15.0 release. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
…r_set_name