Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove ACL in analytics, inventory, and replication examples #292

Merged

Conversation

magreenbaum
Copy link
Member

Description

Some examples still have acl being set with default object ownership getting created with BucketOwnerEnforced which doesn't support ACLs. This just removes acl.

Motivation and Context

Fixes examples which produce error currently:

╷
│ Error: creating S3 Bucket (analytics-and-inventory-destination-fresh-kitten) ACL: operation error S3: PutBucketAcl, https response error StatusCode: 400, RequestID: <>, HostID: <>, api error AccessControlListNotSupported: The bucket does not allow ACLs
│ 
│   with module.analytics_and_inventory_destination_bucket.aws_s3_bucket_acl.this[0],
│   on ../../main.tf line 66, in resource "aws_s3_bucket_acl" "this":
│   66: resource "aws_s3_bucket_acl" "this" {
│ 
╵

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link

github-actions bot commented Nov 8, 2024

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Nov 8, 2024
@magreenbaum
Copy link
Member Author

unstale

@antonbabenko antonbabenko merged commit 1986daa into terraform-aws-modules:master Nov 8, 2024
14 checks passed
antonbabenko pushed a commit that referenced this pull request Nov 8, 2024
## [4.2.2](v4.2.1...v4.2.2) (2024-11-08)

### Bug Fixes

* Remove ACL in analytics, inventory, and replication examples ([#292](#292)) ([1986daa](1986daa))
@antonbabenko
Copy link
Member

This PR is included in version 4.2.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants