feat: Add rules for Promtail and Loki #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uneti-max
changed the title
antonbabenko
pushed a commit
that referenced
this pull request
Jan 13, 2023
## [4.17.0](v4.16.2...v4.17.0) (2023-01-13) ### Features * Add rules for Promtail and Loki ([#277](#277)) ([b0d41e2](b0d41e2))
|
This PR is included in version 4.17.0 🎉 |
|
Awesome thanks! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds rules for Loki and Promtail.
Motivation and Context
When using this repo to create a EC2 instance that will run provide dashboards, I would like to be able to use Promtail and Loki in conjunction with Prometheus and Grafana. This requires additions to the
rules.tffile.Breaking Changes
None that I am aware of
How Has This Been Tested?
This has been tested using the following repo to create an EC2 instance on which a docker-compose is used to deploy Grafana, Prometheus, Promtail, and Loki.
https://github.com/uneti-max/aws-tester
When the instance is done provisioning - Loki, and Promtail can be verified in the Grafana GUI. See screenshot below:
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request