Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed Splunk rule names #301

Merged
merged 1 commit into from
Jan 22, 2024
Merged

fix: Fixed Splunk rule names #301

merged 1 commit into from
Jan 22, 2024

Conversation

andyshinn
Copy link
Contributor

Description

The Splunk rule names didn't align which leads to errors like in #152

Motivation and Context

Fixes #152.

Breaking Changes

Should be none.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@andyshinn andyshinn force-pushed the ashinn/fix-splunk-rule-names branch from dc48c56 to 3bb6c63 Compare November 27, 2023 15:49
@andyshinn andyshinn changed the title Splunk rule names were not in alignment fix: Splunk rule names were not in alignment Nov 27, 2023
@github-actions GitHub Actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Dec 28, 2023
@andyshinn
Copy link
Contributor Author

Not stale.

@github-actions github-actions bot removed the stale label Dec 29, 2023
@antonbabenko antonbabenko changed the title fix: Splunk rule names were not in alignment fix: Fixed Splunk rule names Jan 22, 2024
@antonbabenko antonbabenko merged commit af350fe into terraform-aws-modules:master Jan 22, 2024
70 of 71 checks passed
antonbabenko pushed a commit that referenced this pull request Jan 22, 2024
@semantic-release-bot
chore(release): version 5.1.1 [skip ci]
3b0f4d9 
### [5.1.1](v5.1.0...v5.1.1) (2024-01-22)

### Bug Fixes

* Fixed Splunk rule names ([#301](#301)) ([af350fe](af350fe))
@antonbabenko
Copy link
Member

This PR is included in version 5.1.1 🎉

@andyshinn
Copy link
Contributor Author

Thanks dawg.

@andyshinn andyshinn deleted the ashinn/fix-splunk-rule-names branch January 22, 2024 18:29
@antonbabenko
Copy link
Member

Sorry that it took ages :(

@dhoppe
Copy link
Contributor

dhoppe commented Feb 21, 2024

This PR is included in version 5.1.1 🎉

@antonbabenko Unfortunately this release has not been uploaded to the Terraform registry.
https://registry.terraform.io/modules/terraform-aws-modules/security-group/aws/latest

@antonbabenko
Copy link
Member

@dhoppe Fixed.

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Error: Invalid index" in module "security_group_splunk" v3.3.0
3 participants
@andyshinn @antonbabenko @dhoppe