Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add NAT gateway interface ids output #1006

Conversation

tormodmacleod
Copy link
Contributor

Description

Added output of Network Interface IDs assigned to NAT Gateways

Motivation and Context

We send our flow logs to New Relic. This would save me having to use a data resource to get the network interface IDs as below

data "aws_nat_gateway" "nat_gateway" {
  for_each = toset(module.vpc.natgw_ids)

  id = each.value
}

Breaking Changes

No, there should be no backwards compatibility issues resulting from this change

How Has This Been Tested?

I tested this locally by changing the source of one of my projects which uses the vpc module

@tormodmacleod tormodmacleod changed the title Natgw interface ids output improvement: Add NAT gateway interface ids output Nov 7, 2023
@tormodmacleod tormodmacleod changed the title improvement: Add NAT gateway interface ids output feat: Add NAT gateway interface ids output Nov 8, 2023
Copy link

github-actions bot commented Dec 9, 2023

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Dec 9, 2023
@bryantbiggs bryantbiggs merged commit 898bbaf into terraform-aws-modules:master Dec 11, 2023
19 checks passed
antonbabenko pushed a commit that referenced this pull request Dec 11, 2023
## [5.3.0](v5.2.0...v5.3.0) (2023-12-11)

### Features

* Add NAT gateway interface ids output ([#1006](#1006)) ([898bbaf](898bbaf))
@antonbabenko
Copy link
Member

This PR is included in version 5.3.0 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants